Skip to content

perf: reuse shortcode index when searching emoji - #1415

Open
MrPunyapal wants to merge 1 commit into
dev-null-sh:productionfrom
MrPunyapal:perf/reuse-emoji-shortcode-index
Open

MrPunyapal wants to merge 1 commit into
dev-null-sh:productionfrom
MrPunyapal:perf/reuse-emoji-shortcode-index

Conversation

@MrPunyapal

@MrPunyapal MrPunyapal commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Change

Reuses the emoji shortcode index during search rather than rebuilding it for each lookup. Alias matching and result ranking remain unchanged.

Tests

The focused emoji search component tests passed (5 tests). Type checks and lint passed.

Summary by CodeRabbit

  • No user-facing changes
    • Emoji search behavior and results remain unchanged.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

searchEmoji now iterates the precomputed shortcodeNames list with a for...of loop. Its matching, ranking, and per-emoji best-name selection conditions remain unchanged.

Changes: Emoji search

Layer / File(s) Summary
Iterate shortcode names
resources/js/lib/emoji.ts
searchEmoji iterates shortcodeNames directly instead of filtering Object.keys(shortcodeEmoji) and processing the result with forEach. Matching and selection conditions remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Possibly related PRs

Suggested reviewers: xheaven

Merge Risk: Minimal · up to b0109

The change preserves emoji search behavior while reusing the precomputed shortcode index.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: reusing the shortcode index to improve emoji search performance.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 1
  • Waived: $0.25 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e766193-34a4-4fa1-a40e-1373fe2aa228
Commits

Reviewing files that changed from the base of the PR and between c934501 and b0109f2.

Files selected for processing: 1
  • resources/js/lib/emoji.ts

Limit details: You’ve used all 10 included reviews currently available.

@MrPunyapal
MrPunyapal force-pushed the perf/reuse-emoji-shortcode-index branch from 7f64206 to b0109f2 Compare November 3, 2026 05:56
@MrPunyapal
MrPunyapal marked this pull request as ready for review November 3, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant