[MrPunyapal]

Problem

Touch events can arrive with timestamps older than the previous tap, which can incorrectly satisfy the double-tap interval check.

Change

Ignores out-of-order tap timestamps while preserving the existing time and distance thresholds for valid double taps.

Tests

The full JavaScript unit suite passed (223 tests). Type checks and lint passed.

Summary by CodeRabbit

• Bug Fixes
  • Taps that occur before the previous tap are no longer recognized as double taps.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

isDoubleTap now rejects a current tap timestamp that precedes the previous tap timestamp. A unit test checks that this case returns false.

Changes: Tap timestamp order

Layer / File(s)	Summary
Validate tap timestamp order resources/js/lib/reactions.ts, tests/Unit/Reactions.test.ts	isDoubleTap requires the current tap timestamp to be greater than or equal to the previous tap timestamp. The test checks that a second tap at time 900 is rejected when the first tap was at time 1,000.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested reviewers: xheaven

Merge Risk: Minimal · up to fefab

The change is narrowly scoped and tested; no actionable merge-blocking risk remains.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: ignoring touch taps with out-of-order timestamps.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 2
• Waived: $0.50 (charged $0.00)
• View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7e7d0f52-aecc-4e3f-9a45-f9cb1fa28dd9

Commits

Reviewing files that changed from the base of the PR and between c934501 and fefab4f.

Files selected for processing: 2

• resources/js/lib/reactions.ts
• tests/Unit/Reactions.test.ts

Limit details: You’ve used all 10 included reviews currently available.