You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: keep formatting out of unselected lines - #1412
No actionable comments were generated in the recent review.
Walkthrough
formatMarkdown now adjusts the line-range endpoint when a nonempty selection ends immediately after a newline. Tests cover bulleted and numbered formatting at this boundary and bulleted formatting with a leading newline.
Changes: Markdown formatting
Layer / File(s)
Summary
Selection boundary handling and regression tests resources/js/lib/markdown-format.ts, tests/Unit/MarkdownFormat.test.ts
When a nonempty selection ends immediately after a newline, formatMarkdown excludes the following line. Tests cover bulleted and numbered selections at this boundary and a selection containing a leading newline.
The selection boundary fix is supported by the implementation and regression coverage, with no actionable merge-blocking risk identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: preventing Markdown formatting from affecting unselected lines.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 6470720f-add8-4cfb-bb9e-d3f469e26ef0
Commits
Reviewing files that changed from the base of the PR and between 0a1c95a and a9da0a2.
Files selected for processing: 2
resources/js/lib/markdown-format.ts
tests/Unit/MarkdownFormat.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Problem
Applying inline formatting at a collapsed selection near a trailing newline can include text outside the selected line.
Change
Keeps formatting within the selected range and preserves the caret behavior for collapsed and expanded selections.
Tests
The full JavaScript unit suite passed (224 tests). Type checks and lint passed.
Summary by CodeRabbit