Skip to content

perf: deduplicate changelog authors per day with a set - #1411

Open
MrPunyapal wants to merge 1 commit into
dev-null-sh:productionfrom
MrPunyapal:perf/dedupe-changelog-authors-per-day
Open

MrPunyapal wants to merge 1 commit into
dev-null-sh:productionfrom
MrPunyapal:perf/dedupe-changelog-authors-per-day

Conversation

@MrPunyapal

@MrPunyapal MrPunyapal commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Change

Changelog authors are deduplicated with a per-day Set. First-seen author order and day boundaries remain unchanged.

Tests

Focused changelog tests passed (6 tests). Type checks and lint passed.

Summary by CodeRabbit

  • Bug Fixes

    • Changelog entries now list each author only once per day, in the order they first appear. All commits for that day remain included.
  • Tests

    • Added coverage for changelog days containing many commits from alternating authors.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The changelog now uses a set to track author logins for each calendar day. A test checks that 200 same-day commits remain grouped together and list each author once in first-occurrence order.

Changes: Changelog author tracking

Layer / File(s) Summary
Daily author deduplication
resources/js/lib/changelog.ts, tests/Unit/Changelog.test.ts
The changelog uses a set to track author logins and resets it for each new day. The test checks that 200 same-day commits remain in one day and list each author once in first-occurrence order.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related PRs

  • dev-null-sh/dev-null.sh#1243: Introduced commit authors and day grouping in the changelog, which this change updates to use a set for author tracking.

Suggested reviewers: xheaven, nunomaduro

Merge Risk: Minimal · up to 5876c

The per-day set reset and first-seen author ordering are preserved, with no merge-blocking concern identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: using a per-day Set to deduplicate changelog authors.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 2
  • Waived: $0.50 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 464eb78d-fa7d-43a6-8452-c3d1ad65c354
Commits

Reviewing files that changed from the base of the PR and between c934501 and 5876c47.

Files selected for processing: 2
  • resources/js/lib/changelog.ts
  • tests/Unit/Changelog.test.ts

Limit details: You’ve used all 10 included reviews currently available.

@MrPunyapal
MrPunyapal force-pushed the perf/dedupe-changelog-authors-per-day branch from 4c582a6 to 5876c47 Compare November 3, 2026 05:56
@MrPunyapal
MrPunyapal marked this pull request as ready for review November 3, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant