Repository navigation
docs: add commit now and going live during a timeout to the knowledge base - #1212
sulimanbenhalim wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Can you do another run on this to see if anything else is stale? And rebase lol |
27eb635 to
d5c10e1
Compare
|
rebased onto production and went through the whole thing against the code
one thing I left alone: Mobile apps says you can link an Apple ID on iOS but I couldn't find anything for it on the server yet so not sure if that line is just ahead of a PR |
Summary
KNOWLEDGE_BASE.mdso Tom still answers from the old textChanges
ScheduledCommitSubmissionController.phpValidation
scheduled-commit-submission.storesubmits the queued commit into the usual review process behindThrottleCommitsandPreventPostingInTimeoutwhileuser-live.updatehasPreventPostingInTimeoutanduser-live.destroydoesn't andCreateUserTimeoutnever ends a streamKNOWLEDGE_BASE.mdwhich no test reads and lint still passesbun run test:unithas one failure that production already has since80cca8f4(fix: pooling)Independent review
e83d7c04heada8ee050fchecking each sentence against the controllers and middleware and testsLimitations
Summary by CodeRabbit