Skip to content

docs: add commit now and going live during a timeout to the knowledge base - #1212

Open
sulimanbenhalim wants to merge 2 commits into
dev-null-sh:productionfrom
sulimanbenhalim:docs/kb-commit-now-and-live
Open

sulimanbenhalim wants to merge 2 commits into
dev-null-sh:productionfrom
sulimanbenhalim:docs/kb-commit-now-and-live

Conversation

@sulimanbenhalim

@sulimanbenhalim sulimanbenhalim commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Changes

  • the scheduled commits paragraph says a queued post can be canceled or submitted right away with Commit now which counts against the same 10 per minute limit and its sources link ScheduledCommitSubmissionController.php
  • the timeout paragraph lists going live with the other things a timeout blocks and says a stream that is already live keeps showing and End stream still works

Validation

  • checked against the code and the tests of feat: commit a scheduled commit now #1136 and fix: stop people in timeout from going live #1146: scheduled-commit-submission.store submits the queued commit into the usual review process behind ThrottleCommits and PreventPostingInTimeout while user-live.update has PreventPostingInTimeout and user-live.destroy doesn't and CreateUserTimeout never ends a stream
  • the full gate passed on the first revision (4529 tests with 100% coverage) and the final one only adds two sentences to KNOWLEDGE_BASE.md which no test reads and lint still passes
  • bun run test:unit has one failure that production already has since 80cca8f4 (fix: pooling)

Independent review

  • read-only Claude agent: CODE PASS on base e83d7c04 head a8ee050f checking each sentence against the controllers and middleware and tests

Limitations

  • None

Summary by CodeRabbit

  • Documentation
    • Updated guidance for profile README refreshes, organization discovery, Go live controls, achievements, scheduled commits, and commit sharing.
    • Clarified setup instructions for SSH keys in terminals and GitHub Actions, along with account deletion and timeout restrictions.
    • Updated explanations of knowledge-base search, integrations, and the services used for search and content checks.
    • Clarified that queued posts can be submitted immediately with Commit now, subject to the same limit of 10 submissions per minute as scheduling.
    • Clarified that users cannot go live during a timeout, while an existing stream remains visible and can still be ended.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The knowledge base updates descriptions of product features, commit actions, SSH-key setup, account restrictions, and AI services.

Changes: Knowledge base updates

Layer / File(s) Summary
Product feature documentation
KNOWLEDGE_BASE.md
The contents and feature descriptions cover related commits, organization calls, mobile apps, profile README refresh, organization discovery, live controls, and the achievements tab label.
Commit actions
KNOWLEDGE_BASE.md
The scheduled-commits page documents immediate submission and its shared 10-per-minute limit. Commit-sharing instructions describe copying a link or sending an approved commit in Remotes.
SSH keys and account actions
KNOWLEDGE_BASE.md
The documentation updates GitHub SSH-key synchronization, retained organization commits after account deletion, and actions restricted during a timeout.
AI services and search
KNOWLEDGE_BASE.md
The documentation describes OpenAI embedding generation, cached semantic-search query embeddings, relevance checks, and moderation.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

  • dev-null-sh/dev-null.sh#938: The documentation describes GitHub bio and company details as additional sources for organization pages.
  • dev-null-sh/dev-null.sh#1331: The documentation updates how an organization page can be created; it does not implement the subgroup feature.

Suggested reviewers: wendelladriel

Merge Risk: Minimal · up to d5c10

No actionable merge-blocking risk remains in the reviewed documentation changes.

Architecture risk: Low · up to d5c10

The change affects 1 system.

Changed systems: KNOWLEDGE_BASE.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — KNOWLEDGE_BASE.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in KNOWLEDGE_BASE.md: Adds Related commits to the Features contents list.
  • observed — Modified behavior in KNOWLEDGE_BASE.md: Adds Remotes: org calls to the Features contents list.
  • observed — Modified behavior in KNOWLEDGE_BASE.md: Adds Mobile apps to the Features contents list.
  • observed — Modified behavior in KNOWLEDGE_BASE.md: Adds that a developer can refresh their GitHub profile README immediately with Sync from GitHub; the previous description specified daily refresh only.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the two main documentation changes: adding Commit now behavior and documenting going live during a timeout.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0e1bbe5a-798f-4b52-ae98-81098792888e
Commits

Reviewing files that changed from the base of the PR and between 27eb635 and d5c10e1.

Files selected for processing: 1
  • KNOWLEDGE_BASE.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@paulinevos

Copy link
Copy Markdown
Contributor

Can you do another run on this to see if anything else is stale? And rebase lol

@sulimanbenhalim
sulimanbenhalim force-pushed the docs/kb-commit-now-and-live branch from 27eb635 to d5c10e1 Compare November 3, 2026 22:13
@sulimanbenhalim

Copy link
Copy Markdown
Contributor Author

rebased onto production and went through the whole thing against the code
more had drifted so those are fixed too

  • Contents was missing Related commits and Remotes: org calls and Mobile apps
  • going live is its own button on your profile or "go live" in search now and the card says Watch now
  • the commit Share menu became the … menu in feat: move commit actions into a menu, with follow, mute, block and delete #1371
  • the ranks tab is Unix Ranks
  • timeouts also block pings and starting or joining calls
  • deleting your account keeps the commits you posted as an org along with their images
  • org pages also come from bios and companies and Sync from GitHub refreshes the README right away
  • the terminal and the action only know keys from sign in or Sync from GitHub (or a recheck at most every 5 minutes when you post with a key it already knows)
  • the AI row still said search embeddings go through the Laravel AI SDK and linked the removed app/Services/OpenAI.php

one thing I left alone: Mobile apps says you can link an Apple ID on iOS but I couldn't find anything for it on the server yet so not sure if that line is just ahead of a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants