Draft
Conversation
Developed in WordPress#11205 Props apermo, mukesh27. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61994 602fd350-edb4-49c9-b593-d223f7449a82
Update incorrect uses of `null` as a single parameter type to be `mixed` instead, largely targeting `$deprecated` variable names. Pipe `|` a few `null`s with other valid types where appropriate. Add a missing empty new-line between the `_deprecated_file()` and `_deprecated_argument()` functions. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61995 602fd350-edb4-49c9-b593-d223f7449a82
When an attachment is used by multiple posts, it could be included in `_embed` for a published post even if its `post_parent` is a draft. This commit avoids embedding attachments that are not viewable in this context. Props bor0. Fixes #64183. git-svn-id: https://develop.svn.wordpress.org/trunk@61996 602fd350-edb4-49c9-b593-d223f7449a82
…ded with a `null` parent. Developed in WordPress#11055 Props sky_76, westonruter, ozgursar, sabernhardt. Fixes #64728. git-svn-id: https://develop.svn.wordpress.org/trunk@61997 602fd350-edb4-49c9-b593-d223f7449a82
The `rest_revision_query` filter in `WP_REST_Revisions_Controller::get_items()` carried a cross-reference comment claiming it was documented in the posts controller. This was incorrect, as the posts controller documents `rest_{$this->post_type}_query` — a dynamic hook that fires only for post types managed by `WP_REST_Posts_Controller`.
`WP_REST_Revisions_Controller` extends `WP_REST_Controller` directly (not the posts controller), so the dynamic hook never fires for revisions. `rest_revision_query` is a standalone hook and has never had its own PHPDoc block.
Follow-up to [43584].
Props apermo, mukesh27, SergeyBiryukov.
See #64224.
git-svn-id: https://develop.svn.wordpress.org/trunk@61998 602fd350-edb4-49c9-b593-d223f7449a82
Replace `@group rest-api` with `@group restapi` to unify the tests under the one group name, chosen on the basis that majority rules. Follow up to r61045, r61032. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@61999 602fd350-edb4-49c9-b593-d223f7449a82
…it_link()` which is being passed in some templates. This addresses `arguments.count` errors identified by PHPStan at rule level 1. Developed in WordPress#11242 Follow-up to WordPress/twentyseventeen commits: [WordPress/twentyseventeen@1afb73c 1afb73c], [WordPress/twentyseventeen@7dd3025#diff-88ec0e9d51b04231a448a06c40ced21810e85361ced9481a9248f1075226c6aa 7dd3025], [https://github.com/WordPress/twentyseventeen/blob/69482880b4ae2ec145f60df417423665581a5653/inc/template-tags.php#L104-L128 6948288]. Props sabernhardt, westonruter. See #64680. Fixes #64825. git-svn-id: https://develop.svn.wordpress.org/trunk@62000 602fd350-edb4-49c9-b593-d223f7449a82
This improves how the built Gutenberg asset is retrieved from the GitHub Container Registry to avoid situations where the download fails when the directory already exists. - The related `postinstall` command has changed from `gutenberg:download` to `gutenberg:verify`. - The `--force` option has been removed. `gutenberg:download` will now download a fresh copy every time it's run. - The `gutenberg:verify` script is now the preferred entry point for managing the files within the `gutenberg` directory. It will only trigger a downoad if the hashes do not match, or the folder is missing entirely. Follow up to [61438], [61873], [61874]. Props bernhard-reiter. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62021 602fd350-edb4-49c9-b593-d223f7449a82
In MySQL 8.0, the default authentication plugin changed from `mysql_native_password` to `caching_sha2_password`, which is not available in PHP 7.3 and earlier. The installation testing workflow currently accounts for this, but only for PHP 7.2 & 7.3. It also does not account for a change in MySQL 8.4 which changed the related flag for controlling this from `--default-authentication-plugin` to `--authentication-policy`. This adjusts the flags and surrounding conditions to ensure the correct ones are passed for the right combinations. Props johnbillion. See #64225, #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62022 602fd350-edb4-49c9-b593-d223f7449a82
This excludes MySQL 9.5 jobs for the installation testing workflow. Only the most recent innovation release of MySQL should be tested. Follow up to [61875]. See #64225, #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62023 602fd350-edb4-49c9-b593-d223f7449a82
…date_link()`. Follow-up to [8758], [15564]. Props marian1. Fixes #64764. git-svn-id: https://develop.svn.wordpress.org/trunk@62024 602fd350-edb4-49c9-b593-d223f7449a82
desrosj
force-pushed
the
make-upgrade-test-workflow-context-aware
branch
from
876d6ee to
16f8c0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket:
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.