[Node] Document created/modified time search params on search()

[dishanthirpara-maker]

Fixes descope/etc#9538

What

Documents the time-based user search filters on the Node SDK's search() function, closing the last gap identified in #9538 for this SDK — the fields already existed and worked, they just weren't documented with proper JSDoc.

The search() function's documentation now includes:

• fromCreatedTime / toCreatedTime — filter users by creation time range (epoch milliseconds)
• fromModifiedTime / toModifiedTime — filter users by last-modified time range (epoch milliseconds)

Implementation Details

• Added a JSDoc block above the search() function in lib/management/user.ts documenting all 4 time-filter fields, matching the JSDoc style already used on the deprecated searchAll() function above it.
• Updated the README "Search all users" example to show fromCreatedTime/toModifiedTime usage.
• No functional/type code was changed — these 4 fields already existed on the SearchRequest type (with only inline // comments) and were already wired through to the request body via the ...searchReq spread in search().
• Per explicit scope decision, the deprecated searchAll() function (which does not support these params) was intentionally left untouched.

Verification

Verified that:

• Installed dependencies with npm install (1008 packages) and ran a real TypeScript typecheck: npx tsc --noEmit -p tsconfig.json → "No errors found." This confirms the new JSDoc block and its @param searchReq.xxx tags don't break compilation and are syntactically valid against the project's actual tsconfig.json.
• Manual diff review confirms the change is a JSDoc comment block plus a README edit, added directly above an existing, unmodified arrow function — no logic touched.

Not verified:

• No integration/functional testing against a live Descope API was performed.

Notes

• This is one of 4 coordinated PRs for #9538. Companion PRs: descope-php#133, descope-ruby-sdk#227, go-sdk#822.
• Scope intentionally excludes the deprecated searchAll() function.
• Recommend running the project's normal CI build/test before merge to get real TypeScript verification, since that wasn't possible in this session.

[shuni-bot]

🐕 Review complete — View session on Shuni Portal 🐾

[shuni-bot]

🐕 Suggested Reviewers

The review assignment considers breadth of file coverage and expertise, selecting contributors who have worked on both the core logic and documentation to ensure high-quality review.

Reviewer	Reason
dorsha	dorsha has extensive commit history across both README.md and lib/management/user.ts, indicating familiarity with the codebase and documentation updates.
aviadl	aviadl contributed to both README.md and user management files, offering a balanced perspective on both documentation and code logic.
asafshen	asafshen's commits are focused on lib/management/user.ts, making them well-suited to review the new time filtering features in the SDK.
yosiharan	yosiharan's contributions are also concentrated on user management, providing targeted expertise for the functional changes.
talaharoni	talahanoni's focus on README.md makes them a good reviewer for documentation clarity and correctness.

_{Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.}

[shuni-bot]

🐕 Shuni's Review

Docs-only PR: adds a JSDoc block for user.search() covering the four time-range filters and updates the README example. No functional code touched — the fields were already on SearchRequest and already forwarded via the ...searchReq spread, and user.test.ts:1300-1320 already asserts they reach the request body.

Sniffed out 1 issue:

• 1 🟡 MEDIUM: new docs assert inclusive time bounds, contradicting the existing field comments in the same file

Good bones otherwise — JSDoc placement and style match the neighbouring searchAll() block. Woof!

---

Declared coverage: FULL — 2/2 changed files reviewed.

[shuni-bot]

🟡 MEDIUM — New docs claim inclusive bounds ("on or after"/"on or before"), but the existing field comments at lib/management/user.ts:60-63 say "after"/"before" (exclusive). Same inclusive wording is repeated in README.md:913-914.

Since this PR's whole purpose is documenting these params, the boundary semantics need to be right: anyone chunking a time window (feeding the previous page's max created time into the next fromCreatedTime) will either double-count or skip users at the boundary depending on which is true.

Fix: confirm the actual server-side comparison, then use one consistent phrasing across the JSDoc, the type comments, and the README.