feat(user): add verifiedEmail and verifiedPhone filters to user search#704
feat(user): add verifiedEmail and verifiedPhone filters to user search#704
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
There was a problem hiding this comment.
🐕 Shuni's Review
Adds verifiedEmail and verifiedPhone optional boolean filters to the SearchRequest type for user search. The existing spread pattern in search and searchTestUsers means the new fields are automatically forwarded — no plumbing changes needed.
No issues found — good bones! Clean type addition, test covers the pass-through, README updated. Woof!
There was a problem hiding this comment.
Pull request overview
Adds support for filtering management user searches by verified email/phone status, aligning the Node SDK search request shape with the API’s filtering capabilities and documenting the new options.
Changes:
- Extended the user
SearchRequesttype to includeverifiedEmailandverifiedPhoneboolean filters. - Added a unit test ensuring these new filters are passed through in the
management.user.searchrequest body. - Updated README user search example to demonstrate the new filters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/management/user.ts | Adds verifiedEmail / verifiedPhone to the search request type so callers can supply these filters. |
| lib/management/user.test.ts | Verifies management.user.search forwards verifiedEmail / verifiedPhone to the HTTP client request body. |
| README.md | Documents the new user search filters in the example snippet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
verifiedEmailandverifiedPhoneboolean filter fields to theSearchRequesttype in user managementTest plan
verifiedEmail: trueandverifiedPhone: falsefilter scenarios🤖 Generated with Claude Code