-
Notifications
You must be signed in to change notification settings - Fork 67
verify updater container image signatures using cosign #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
OpenTelemetry containers are also signed with cosign: |
|
@JamieMagee - could you rebase & resolve the conflicts, please? I would hope to see this completed and merged - verifying the sigstore signatures is a great idea! 💯 |
919e74b to
8ce539f
Compare
|
@dmitris done and done. I updated to v2 of cosign and added signature verification of the default OpenTelemetry container as well. Once the proxy container is signed this can be easily added as well. |
60e4d41 to
13ac0ad
Compare
|
👍 on the overall idea. When debugging, we may need to specify a custom version of the image... it's been a bit since I last did it, so I don't remember for sure if I was specifying an image that I'd built locally or from a PR against What would a developer need to do to get this signature verification to play nice with that workflow? Is it just commenting out a line of code somewhere? |
|
@jeffwidman You just need to add |
one more time, please ( |
|
Cosign v2 seems like the right path here given that this is a public repo, but I'm copying Cody and Zach in case they think it makes sense to use the GH CLI's attestation package as an alternative. In any case I'm glad to see us using the Cosign updates that @codysoyland worked so hard to get merged upstream! 😆 |
|
@trevrosen I'd also be interested to get a review on my use of the sigstore APIs. I'm not super familar with them, and want to make sure I'm using them correctly. Also, here's the signing part of this in our |
|
Hey! I'm a Cosign maintainer and work on GitHub Artifact Attestations. We recently added support for Sigstore Bundles as OCI referring artifacts for Cosign attestations using the |
13ac0ad to
f89da78
Compare
|
Thanks to @codysoyland for all the help. I've managed to update this branch to use the new sigstore attestation bundle format. Unfortunately, the attestations we've been pushing until now have been using the old bundle format. However, Cody has sent out a PR to |
Now that the updater container images are signed as part of dependabot/dependabot-core#9546, we need to verify those signatures when using those container images.
This change allows us to verify that the container images we pull were build by a GitHub Actions workflow in the main branch of https://github.com/dependabot/dependabot-core.
The code is equivalent to running:
TODO:
Related to #308