fix callbacks lifetime #89
Merged
+151
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callbacks now are preserved in a glonbal map, and they're removed from it when callback.destory is called, this is because JS GC can't reason about them correctly autocallbacks now just leak the callback, they're considerd now a convience function, if the user wants to control memory they can use python.callback add gtk.ts test becasue it just a nice stress test, I want add it to the ci but its just for manual testing
Contributor
Author
|
Also I now plan to publish a fork in jsr @sigma/python , because I use this project for many stuff (https://flathub.org/en/apps/io.github.sigmasd.stimulator and others) I prefer to have a faster way to iterate on this core component Obviously I'll try to upstream any relevant addition when I can |
eliassjogreen
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callbacks now are preserved in a glonbal map, and they're removed from it when callback.destory is called, this is because JS GC can't reason about them correctly
autocallbacks now just leak the callback, they're considerd now a convience function, if the user wants to control memory they can use python.callback
add gtk.ts test becasue it just a nice stress test, I want add it to the ci but its just for manual testing
supersedes #87