ci: unpin Node.js, test against lts/* and latest#7241
Open
tomas-zijdemans wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7241 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 617 618 +1
Lines 51674 51677 +3
Branches 9326 9326
=======================================
+ Hits 49093 49097 +4
Misses 2038 2038
+ Partials 543 542 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpins the Node CI matrix from 24.2.0 and runs the tests against
lts/*andlatestinstead.The pin was a workaround for nodejs/node#58826, an
fs.chowncrash on uid -1 that @kt3k hit on Node 24.3. The fix shipped in Node 24.4.0 on July 9, 2025, so the TODO to restorelatesthas been actionable for a year.Why two entries: latest is Node 26, which ships V8 14 builtins like
Uint8Array.prototype.toBase64. Node 24 LTS does not have them, and it is what most@stdconsumers on npm run until 2028. Keepinglts/*in the matrix means a change that leans on a 26-only builtin fails CI instead of failing users.Tested by CI itself. The test-node job now runs twice, once per Node line.