feat(data-structures/unstable): add Readonly view and clone path to RollingCounter#7234
Open
tomas-zijdemans wants to merge 3 commits into
Open
feat(data-structures/unstable): add Readonly view and clone path to RollingCounter#7234tomas-zijdemans wants to merge 3 commits into
tomas-zijdemans wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two additive changes, each adopting a pattern already used by sibling data structures.
ReadonlyRollingCounter, aPick<>view of the non-mutating members.RollingCounternowimplements ReadonlyRollingCounterfor a compile-time guarantee. MatchesReadonlyDequeandReadonlyIndexedHeap.RollingCounter.from()to accept aRollingCounterin addition to aRollingCounterSnapshot. The instance path produces an independent clone with a canonical layout (segments oldest-to-newest, cursor at the last position). MatchesDeque.from(deque)andIndexedHeap.from(otherHeap).No behavior changes for existing call sites.
Note
Recreates #7161, which was closed automatically when I accidentally deleted the head fork. The branch is identical to the original PR head.