Skip to content

fix(fs): return Generator from walkSync and expandGlobSync so iterator helpers are visible #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeSingh1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(fs): return Generator from walkSync and expandGlobSync so iterator helpers are visible #7166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75c8d5
fix(fs): return Generator from walkSync and expandGlobSync
LeSingh1 May 29, 2026
a6756d0
fix: pin Generator type params for Deno v1.x yield* delegation
LeSingh1 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fs/expand_glob.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ export async function* expandGlob(
export function* expandGlobSync(
glob: string | URL,
options?: ExpandGlobOptions,
): IterableIterator<WalkEntry> {
): Generator<WalkEntry, void, undefined> {
let {
root,
exclude = [],
Expand Down Expand Up @@ -473,7 +473,7 @@ export function* expandGlobSync(
function* advanceMatch(
walkInfo: WalkEntry,
globSegment: string,
): IterableIterator<WalkEntry> {
): Generator<WalkEntry, void, undefined> {
if (!walkInfo.isDirectory) {
return;
} else if (globSegment === "..") {
Expand Down
2 changes: 1 addition & 1 deletion fs/walk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ export async function* walk(
export function* walkSync(
root: string | URL,
options?: WalkOptions,
): IterableIterator<WalkEntry> {
): Generator<WalkEntry, void, undefined> {
let {
maxDepth = Infinity,
includeFiles = true,
Expand Down
Loading