BREAKING(async/unstable): change Lazy.peek() return type, add AbortSignal support#7084
Open
tomas-zijdemans wants to merge 4 commits intodenoland:mainfrom
Open
BREAKING(async/unstable): change Lazy.peek() return type, add AbortSignal support#7084tomas-zijdemans wants to merge 4 commits intodenoland:mainfrom
Lazy.peek() return type, add AbortSignal support#7084tomas-zijdemans wants to merge 4 commits intodenoland:mainfrom
Conversation
Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7084 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 630 630
Lines 50490 50508 +18
Branches 8949 8953 +4
=======================================
+ Hits 47669 47688 +19
Misses 2249 2249
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomas-zijdemans
changed the title
Lazy APILazy.get()
tomas-zijdemans
changed the title
Lazy.get()Lazy.get()
tomas-zijdemans
changed the title
Lazy.get()Lazy.peek() return type, add AbortSignal support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get()get()silently swallowed rejections by attaching a handler directly to the returned promise, suppressing unhandledrejection for uncaught callers.peek()now returns a discriminated union matching theChannel.tryReceive()convention. This resolves the type-level ambiguity when T includes undefined.