feat(data-structures/unstable): add includes() and removeAt() to Deque#7083
Open
tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Open
feat(data-structures/unstable): add includes() and removeAt() to Deque#7083tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
includes() and removeAt() to Deque#7083tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Conversation
Dequeincludes() and removeAt() to Deque
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7083 +/- ##
==========================================
- Coverage 94.41% 94.41% -0.01%
==========================================
Files 630 630
Lines 50490 50551 +61
Branches 8949 8959 +10
==========================================
+ Hits 47669 47726 +57
- Misses 2249 2252 +3
- Partials 572 573 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes()method (matchingArray.prototype.includes), andremoveAt(index)for removing elements by index with negative-index support.BinaryHeapdocs.[Symbol.iterator]()andreversed()with manual iterator objects, useslice/concatintoArray()and#copyBufferinstead of per-element loops, and add a fast path inDeque.from()for plain arrays without a map function#maybeGrow()and#removeAtUnchecked()private helpers to reduce duplication