fix(csv): return empty array for empty input with skipFirstRow #6912
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6809
When parsing an empty string with
skipFirstRow: true, the function was throwing a TypeError because there were no headers to extract. This is inconsistent with parsing an empty string without options, which returns an empty array.Problem
Solution
Return an empty array when there's no data to parse, instead of throwing an error.
Changes
if (options.skipFirstRow) { const head = r.shift(); if (head === undefined) { - throw new TypeError("Cannot parse input: headers must be defined"); + return [] as ParseResult<ParseOptions, T>; } headers = head; }After