refactor(yaml): eliminate shared class state by passing parameters in LoaderState
#6902
+317
−239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
tag,anchor,kindandresultclass properties inLoaderStateand passes aStateobject to methods that change these properties.It also makes
read*()methods return aStateto which automatically entangles lots of nested if/else statements.This reduces the code complexity massively because these properties are changed recursively and sometimes also backtracked which makes the code very hard to follow and methods not
This also opens the door to reduce the code further in future PRs because it makes redundant code and simplifications obvious.