Repository navigation
release 0.0.9909 - #150
release 0.0.9909#150
Conversation
avocet-bot
left a comment
There was a problem hiding this comment.
Review: #150 — "release 0.0.9909"
Reviewed head SHA: 58c5078ecb3cd023b9bb66e938a619e47ec8afc7
Base: main · Head branch: release-0.0.9909
What this PR does (for a reader new to the repo)
deploy-cli is the deno deploy command-line client. It is published to JSR
as the @deno/deploy package; the package's published version is taken from the
single version field in deno.json at the repository root. A "release PR" in
this repo is the mechanical step that advances that version field so the next
publish ships under a new, previously-unpublished version number.
This PR is exactly that mechanical bump and nothing more:
--- a/deno.json
+++ b/deno.json
@@ -4,7 +4,7 @@
"astro-demo"
],
"name": "@deno/deploy",
- "version": "0.0.9908",
+ "version": "0.0.9909",
"license": "MIT",The PR body attributes the release content to #149 — the fix that stops
deno deploy from hanging on "Loading previously uploaded files..." (or dying
with "Top-level await promise never resolved") when the build fails, is
cancelled, or is superseded before the server reports which files to upload.
That change now exits with the revision's status / failure message / build URL
(REVISION_FAILED / REVISION_CANCELLED, exit 1) or with exit 6 and
DIFFSYNC_STREAM_ENDED / DIFFSYNC_MALFORMED_RESPONSE / DIFFSYNC_TIMEOUT.
Control/data flow verification
- Diff is only the version bump.
gh pr viewreports a single changed file
(deno.json, +1/-1), and the head commit touches only that file. Nothing
else is bundled in. - Version string is well-formed and consistent.
0.0.9908→0.0.9909is a
monotonic +1 patch increment, matches the PR title and body, and leaves the
JSON structurally valid (one scalar value changed). - The #149 provenance claim checks out. PR #149 is already merged into
main(merge commit7bf3358, 2026-11-02T04:43:26Z). This release head
commit58c5078was authored ~21s later and its single parent is exactly
7bf3358. That is whybase...headreduces to just the version line: #149's
behavior changes are already inmain, so this PR contributes only the bump.
The body's reference to #149 is accurate. (main'sdeno.jsonstill reads
0.0.9908, which is expected until this PR merges.) - Release-pipeline risk: none. The
versionfield feeds the JSR publish of
@deno/deploy.0.0.9909is a fresh, higher, previously-unpublished value,
so there is no overwrite/collision risk, and no code or config path other than
the version is affected.
Findings
None. This is a clean, textbook release bump: the diff is exactly the single
version line, the value is well-formed and monotonic, and the referenced
feature work (#149) is already merged into the base branch.
Review skill evidence
I invoked the pr-review-toolkit:code-reviewer subagent (via the Task/Agent
tool) to independently gather the diff, confirm the single-file scope, validate
the version string, and verify the #149 merge provenance (merge commit
7bf3358 as the sole parent of head 58c5078). Its verdict — no blocking or
non-blocking issues — matches this review.
Verdict: Approve.
Bumps the version in
deno.jsonto0.0.9909. Includes:deno deployno longer hangs on "Loading previously uploadedfiles..." (or exits with "Top-level await promise never resolved")
when the build fails, is cancelled or is superseded before the server
reports which files to upload. It now exits with the revision's
status, failure message and build URL (
REVISION_FAILED/REVISION_CANCELLED, exit 1), or with exit 6 andDIFFSYNC_STREAM_ENDED/DIFFSYNC_MALFORMED_RESPONSE/DIFFSYNC_TIMEOUT(after 10 minutes). FixesCLI: publish crashes with 'Top-level await promise never resolved' when watchUntilReady closes early deploy_feedback#949.