Skip to content

release 0.0.9908 - #148

Merged
piscisaureus merged 1 commit into
mainfrom
release-0.0.9908
Oct 1, 2026
Merged

piscisaureus merged 1 commit into
mainfrom
release-0.0.9908

Conversation

@piscisaureus

Copy link
Copy Markdown
Member

Bumps the version in deno.json to 0.0.9908. Includes:

* #146 send deno.json to the console on every deploy
* #147 --build-timeout accepts a unit suffix
* @deno/framework-detect 0.3.4: app directories like apps/web/ or ./

@avocet-bot avocet-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — #148 "release 0.0.9908"

Reviewed head SHA: d99107e0178fc191df6543320501bc2845566939
Verdict: Approve — no blocking issues.

What this PR is

deploy-cli is the deno deploy command-line tool. Its version is declared in a single source of truth, deno.json (field version), and version.ts imports that JSON and re-exports it as VERSION, so the CLI reports the same number at runtime. Third-party dependencies are declared as JSR/npm specifiers in deno.json imports and pinned to exact resolved versions + integrity hashes in deno.lock.

This is a routine release PR: it cuts a new version and rolls in work that already landed on main via separate PRs. The diff touches only two files:

  • deno.json: version 0.0.9907 → 0.0.9908; @deno/framework-detect specifier ^0.3.3 → ^0.3.4.
  • deno.lock: the three framework-detect lines — the top-level specifier map (~0.3.3→~0.3.4), the package entry (@deno/framework-detect@0.3.3 → @0.3.4, integrity 6276…ddc8 → a8ab…7649, transitive deps unchanged), and the workspace-member dep list (~0.3.3→~0.3.4).

The PR body credits already-merged #146 (deno deploy sends the app directory's deno.json on every deploy) and #147 (--build-timeout accepts a unit suffix like 10m/600s). Those changes are not in this diff — they merged earlier — so they are out of scope here; this diff is purely the version string plus the single JSR dependency bump (denoland/deployng#3774: workspace/app directories such as ./packages/a/ are now detected).

Verification performed

Reviewed at the live head SHA d99107e (matches headRefOid), so no checkout drift. The pr-review-toolkit:code-reviewer agent plus independent checks on a fresh clone of the PR head confirmed:

  1. Specifier ↔ lock consistency — consistent, no stale pin. deno.json reads ^0.3.4; deno.lock resolves 0.3.4 in all three locations. The lock keys read ~0.3.4 while deno.json reads ^0.3.4; this is Deno's canonical normalization, not drift — for a 0.x.y version ^0.3.4 and ~0.3.4 denote the identical range (>=0.3.4 <0.4.0), and the same ^(json)/~(lock) pairing existed for 0.3.3 before this PR. grep over deno.lock/deno.json on the PR head finds no residual 0.3.3 / ~0.3.3 / ^0.3.3 reference.

  2. Version bumped consistently — single source of truth. deno.json:7 is the only occurrence of the release version anywhere in the repo (grep for 9907/9908 returns only that line). version.ts imports deno.json dynamically rather than hard-coding, and rs_lib/Cargo.toml carries an independent 0.0.0 unrelated to the CLI release version.

  3. Integrity hash — verified against JSR. sha256 of jsr.io/@deno/framework-detect/0.3.4_meta.json equals a8abfde986605990b2729ba778421d65209acdd122174d79fe2e54b487c97649, an exact match for the lock. 0.3.4 is the current latest on JSR. The 0.3.4 dependency graph (jsr:@std/jsonc, jsr:@std/path@^1.1.2) is identical to 0.3.3's, so the unchanged dependencies array in the lock is correct and both transitive packages are already resolved — no new/missing lock entry.

  4. No correctness/regression/security risk from this diff. A patch-level bump of one JSR dependency plus the version string. PR CI (jsr, deno) is green.

Findings

None. This is a correct, low-risk release PR. The only thing that superficially looks like a discrepancy — ^ in deno.json vs ~ in deno.lock — is expected Deno canonicalization, not lockfile drift.

Review skill evidence

Invoked the pr-review-toolkit:code-reviewer agent (via the Task/Agent tool) to perform the dependency/lockfile/version verification, supplemented by direct gh/git/grep checks on a fresh clone of the PR head and a JSR _meta.json integrity-hash check.

@piscisaureus
piscisaureus merged commit 30a16df into main Oct 1, 2026
4 checks passed
@piscisaureus
piscisaureus deleted the release-0.0.9908 branch October 1, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants