AV0125: Consider duplicating simple logic across modules to reduce coupling#369
AV0125: Consider duplicating simple logic across modules to reduce coupling#369dennisdoomen wants to merge 2 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
The old AV1580 was removed and then I created this new one as a companion to #306.
There was a problem hiding this comment.
Well, the new content basically elaborates on the exception in #306, so in my opinion, it belongs there. It's confusing to repurpose existing rule numbers for something else; users may already have suppressions in their codebase, so we should assign a new number if we need a new rule. And I don't see why the original rule no longer applies, so I believe we should keep it.
There was a problem hiding this comment.
I agree with you and will add it to AV0125
The original rule definitely doesn't apply anymore as all debuggers these days show all the individual parts of a nested call. Rider even allows you to step into the individual parts. Moved that in #392
Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ea0b1a0 to
149b8cf
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This PR updates guideline AV1580.
It was split out of #298 so the change can be reviewed independently.
Files:
Part of the replacement for #298.