Skip to content

AV0125: Consider duplicating simple logic across modules to reduce coupling#369

Open
dennisdoomen wants to merge 2 commits intodevelopfrom
copilot/pr298-update-av1580
Open

AV0125: Consider duplicating simple logic across modules to reduce coupling#369
dennisdoomen wants to merge 2 commits intodevelopfrom
copilot/pr298-update-av1580

Conversation

@dennisdoomen
Copy link
Copy Markdown
Owner

This PR updates guideline AV1580.

It was split out of #298 so the change can be reviewed independently.

Files:

  • _rules/1580.md

Part of the replacement for #298.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong here while splitting into separate PRs. The new text partly overlaps with #306 and #300 while being unrelated to the original rule.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old AV1580 was removed and then I created this new one as a companion to #306.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the new content basically elaborates on the exception in #306, so in my opinion, it belongs there. It's confusing to repurpose existing rule numbers for something else; users may already have suppressions in their codebase, so we should assign a new number if we need a new rule. And I don't see why the original rule no longer applies, so I believe we should keep it.

Copy link
Copy Markdown
Owner Author

@dennisdoomen dennisdoomen Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you and will add it to AV0125

The original rule definitely doesn't apply anymore as all debuggers these days show all the individual parts of a nested call. Rider even allows you to step into the individual parts. Moved that in #392

@dennisdoomen dennisdoomen changed the title Update AV1580: Consider duplicating simple logic across modules to reduce coupling AV1581: Consider duplicating simple logic across modules to reduce coupling Apr 12, 2026
Split from #298.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dennisdoomen dennisdoomen force-pushed the copilot/pr298-update-av1580 branch from ea0b1a0 to 149b8cf Compare April 12, 2026 07:07
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dennisdoomen dennisdoomen changed the title AV1581: Consider duplicating simple logic across modules to reduce coupling AV0125: Consider duplicating simple logic across modules to reduce coupling Apr 12, 2026
@dennisdoomen dennisdoomen requested a review from bkoelman April 12, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants