refactor!: Remove deprecated Toolset addition APIs - #12353
Closed
krishna3554 wants to merge 1 commit into
Closed
Conversation
|
@krishna3554 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
krishna3554
changed the title
Member
|
Sorry. This issue is not open for contributions and must be done after Haystack 3.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Toolset: remove deprecated__add__; remove deprecatedadd(toolset)#12302Proposed Changes:
Toolset.__add__.Toolset.add(toolset)support;add()now accepts onlyTool._ToolsetWrapper, which only existed to supportToolset.__add__.__add__stubs fromSearchableToolsetandSkillToolset.toolset.add(tool)behavior and removed tests for deprecated+behavior.How did you test it?
rg "__add__|_ToolsetWrapper|ToolsetWrapper|toolset \\+|\\+ toolset" haystack testand confirmed no active code/test references remain.hatch run test:unit ...locally becausehatchis not installed.Notes for the reviewer
This follows the planned removal after the deprecations introduced in #12298.
_ToolsetWrapperwas removed because it only supported the deprecated+path.