refactor: consolidate duplicated class-import logic between core/serialization and type_serialization#11897
Closed
davidsbatista wants to merge 5 commits into
Closed
refactor: consolidate duplicated class-import logic between core/serialization and type_serialization#11897davidsbatista wants to merge 5 commits into
davidsbatista wants to merge 5 commits into
Conversation
Co-authored-by: sjrl <10526848+sjrl@users.noreply.github.com>
Co-authored-by: Julian Risch <julian.risch@deepset.ai> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…alization and type_serialization
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
import_class_by_name(core/serialization.py) anddeserialize_type(utils/type_serialization.py) each reimplemented the same "split a dotted path, import the module,getattrthe class" logic.type_serialization.pyas_import_class_by_nameloggingimport fromcore/serialization.py, caught a real bug:components/tools/tool_invoker.pywas accidentally importingloggingthroughcore/serialization.pyinstead of fromhaystackdirectlyhaystack.loggingHow did you test it?
tool_invoker.pyregression before it shipped.Notes for the reviewer
import_class_by_nameis now a one-line wrapper around_import_class_by_namewhich is private totype_serialization.py, and 9 files importimport_class_by_namefromcore/serialization.pydeserialize_chatgenerator_inplacewrappingdeserialize_component_inplaceChecklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.