Skip to content

chore: removing dead-code + tests#11889

Closed
davidsbatista wants to merge 6 commits into
v3from
chore/remove-de-serialize_class_instance
Closed

chore: removing dead-code + tests#11889
davidsbatista wants to merge 6 commits into
v3from
chore/remove-de-serialize_class_instance

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Related Issues

  • Partially fixes #450

Proposed Changes:

  • Removes serialize_class_instance and deserialize_class_instance
  • Also removed the corresponding tests and fixtures (CustomClassNoToDict, CustomClassNoFromDict)
  • Their functionality is superseded by _serialize_value_with_schema/_deserialize_value_with_schema

How did you test it?

  • Ran the existing unit test suite for the affected module: hatch run test:unit test/utils/test_base_serialization.py
  • Grepped for remaining references to confirm no other call sites exist.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jul 7, 2026 2:23pm

Request Review

@github-actions github-actions Bot added topic:tests type:documentation Improvements on the docs labels Jul 6, 2026
@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage report

Warning

The diff for this PR is too large to be retrieved from GitHub's API (maximum 300 files). Diff coverage is not available for this PR.

This PR does not seem to contain any modification to coverable code.

@davidsbatista davidsbatista marked this pull request as ready for review July 6, 2026 16:00
@davidsbatista davidsbatista requested a review from a team as a code owner July 6, 2026 16:00
@davidsbatista davidsbatista requested review from sjrl and removed request for a team July 6, 2026 16:00
@claude

claude Bot commented Jul 6, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@davidsbatista davidsbatista mentioned this pull request Jul 6, 2026
Merged
HaystackBot and others added 4 commits July 7, 2026 08:24
@HaystackBot @sjrl
Bump unstable version and create unstable docs (#11894)
c5c8240 
Co-authored-by: sjrl <10526848+sjrl@users.noreply.github.com>
@davidsbatista @julian-risch @claude
fix: raise DeserializationError for unimportable classes (#11890)
da17b3e 
Co-authored-by: Julian Risch <julian.risch@deepset.ai>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@sjrl
Revert "fix: updating generated answer and extracted answers serialis…
8d037f2 
…ation (#11805)" (#11895)
@davidsbatista
Merge branch 'main' into chore/remove-de-serialize_class_instance
5c38a6a
@davidsbatista davidsbatista changed the base branch from main to v3 July 7, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrl sjrl Awaiting requested review from sjrl sjrl is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees

No one assigned

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidsbatista @HaystackBot @sjrl