fix: correct log placeholder kwarg for untriggered pipeline breakpoint warning#11885
Open
Kropiunig wants to merge 1 commit into
Open
fix: correct log placeholder kwarg for untriggered pipeline breakpoint warning#11885Kropiunig wants to merge 1 commit into
Kropiunig wants to merge 1 commit into
Conversation
|
@Kropiunig is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
Hi @Kropiunig - can you please sign the CLA? |
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning that fires when a pipeline breakpoint is never triggered used the placeholder
{break_point}in its message, but passed the value under the kwargpipeline_breakpoint. Haystack's logger catches the resulting KeyError frommsg.format(**safe_extra)and falls back to the raw string, so users saw the literal text{break_point}instead of the actual breakpoint.Renaming the kwarg to
break_pointso it matches the placeholder makes the message interpolate the real value. One-line change; the message string is unchanged.