fix: preserve zero scores in document joiner#11355
Open
wolfkill wants to merge 1 commit into
Open
Conversation
|
@wolfkill is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Member
|
This is a duplicate of #11353 and the CLA is not signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DocumentJoinerduplicate selection inconcatenatemode soscore=0.0is compared as a real scoreNonecheckWhy
DocumentJoiner._concatenateused a truthiness check for scores. Since0.0is falsy in Python, a duplicate document withscore=0.0was treated like an unscored document and could lose to a worse negative score.Testing
hatch -e test run pytest test/components/joiners/test_document_joiner.py::TestDocumentJoiner::test_run_with_concatenate_join_mode_keeps_duplicate_document_with_zero_score -qhatch -e test run pytest test/components/joiners/test_document_joiner.py -qenv -u ALL_PROXY -u HTTPS_PROXY -u HTTP_PROXY -u all_proxy -u https_proxy -u http_proxy hatch -e test run pytest test/components/joiners -qhatch run fmt-check haystack/components/joiners/document_joiner.py test/components/joiners/test_document_joiner.pyhatch run test:types haystack/components/joiners/document_joiner.pyhatch -e test run python -m compileall -q haystack/components/joiners/document_joiner.py test/components/joiners/test_document_joiner.pygit diff --checkCloses #11352