fix: enforce max_runs_per_component limit correctly#11334
Open
rautaditya2606 wants to merge 1 commit into
Open
fix: enforce max_runs_per_component limit correctly#11334rautaditya2606 wants to merge 1 commit into
rautaditya2606 wants to merge 1 commit into
Conversation
Use visits >= max_runs_per_component so components cannot run more times than the configured limit within a single Pipeline.run() call. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@rautaditya2606 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes an off-by-one bug in pipeline component run limiting so components cannot execute more than max_runs_per_component times within a single Pipeline.run().
Changes:
- Tighten the run-limit check from
>to>=formax_runs_per_component. - Update the regression test to assert the limit triggers exactly at the configured max.
- Add a release note documenting the bugfix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
haystack/core/pipeline/base.py |
Fixes the boundary condition in the max-runs enforcement logic (>= instead of >). |
test/core/pipeline/test_pipeline_base.py |
Updates the failing boundary test to match the corrected enforcement behavior. |
releasenotes/notes/fix-pipeline-max-runs-off-by-one-4a8e2f1c9b3d7051.yaml |
Documents the off-by-one fix for users. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
max_runs_per_componentcheckedvisits > maxbefore each run whilevisitsincrements after the run, allowing one extra execution (e.g. 101 runs when the limit is 100). Usevisits >= maxso behavior matches the documented limit.How did you test it?
test__get_next_runnable_component_max_visitsintest/core/pipeline/test_pipeline_base.pyhatch run test:unit test/core/pipeline/test_pipeline_base.py::TestPipelineBase::test__get_next_runnable_component_max_visitsChecklist