Skip to content

Conversation

@julian-risch
Copy link
Member

@julian-risch julian-risch commented Jan 20, 2026

Related Issues

Proposed Changes:

  • Drop to_dict and deserialize_secrets_inplace where Secrets are handled in (de-)serialization
  • Remove imports that are no longer used
  • Correct a few docstrings where to_dict and from_dict docstrings were mixed up

How did you test it?

  • unit tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@julian-risch julian-risch requested a review from a team as a code owner January 20, 2026 16:07
@julian-risch julian-risch requested review from davidsbatista and removed request for a team January 20, 2026 16:07
@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jan 20, 2026 5:17pm

Request Review

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jan 20, 2026
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsbatista
Copy link
Contributor

@julian-risch looks good - I think we can also open an issue to do the same in the integrations.

@julian-risch
Copy link
Member Author

julian-risch commented Jan 20, 2026

@julian-risch looks good - I think we can also open an issue to do the same in the integrations.

Yes, I can do that. Will be blocked by the Haystack release for now but not for long. 🙂

@julian-risch julian-risch merged commit 6c229d0 into main Jan 21, 2026
23 checks passed
@julian-risch julian-risch deleted the simplify-serde-secrets branch January 21, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify to_dict, from_dict with default (de-)serialization of Secrets

3 participants