Skip to content

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 20, 2026

Related Issues

Proposed Changes:

Add type checking to the test/core/pipeline/ folder.

How did you test it?

Running typing tests on the newly added folder.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl sjrl requested a review from a team as a code owner January 20, 2026 14:32
@sjrl sjrl requested review from anakin87 and removed request for a team January 20, 2026 14:32
@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
haystack-docs Ignored Ignored Jan 20, 2026 3:16pm

Request Review

@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jan 20, 2026
@sjrl sjrl self-assigned this Jan 20, 2026

name: str
type: type
type: type | UnionType
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change needed outside of test folder. Without this then passing something like type=int | str would cause mypy to throw an error.

@anakin87
Copy link
Member

I see there's a type error.

(Over time, let's also check if mypy running time increases significantly)

@sjrl
Copy link
Contributor Author

sjrl commented Jan 20, 2026

I see there's a type error.

(Over time, let's also check if mypy running time increases significantly)

@anakin87 I'll need to investigate this more about how we can properly support this. I'm not too familiar with how python treats type but it looks like UnionType doesn't count as a type which cascades down into more issues in our type_util methods. I'll see if there is a reasonable way to get it working short of setting type: Any

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:core topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants