Skip to content

Conversation

@Amnah199
Copy link
Contributor

No description provided.

@Amnah199 Amnah199 requested a review from a team as a code owner September 25, 2025 13:14
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bilgeyucel bilgeyucel self-assigned this Oct 6, 2025
@Amnah199 Amnah199 requested a review from anakin87 December 2, 2025 13:35
@@ -0,0 +1,539 @@
{
Copy link
Member

@anakin87 anakin87 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's use "GPT" (all capitalized) everywhere


Reply via ReviewNB

@@ -0,0 +1,539 @@
{
Copy link
Member

@anakin87 anakin87 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity (and consistency with the Responses example), we can avoid using a Pipeline and removing ChatPromptBuilder. WDYT?


Reply via ReviewNB

@@ -0,0 +1,539 @@
{
Copy link
Member

@anakin87 anakin87 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets' use "JSON" (all capitalized) everywhere


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants