-
Notifications
You must be signed in to change notification settings - Fork 23
Add Mem0 integration - support for Mem0 platform #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 21253212844Details
💛 - Coveralls |
…ental into mem0-integration
haystack_experimental/memory_stores/examples/memory_store_with_agent.py
Outdated
Show resolved
Hide resolved
|
@Amnah199 I noticed that the tests are failing for AWS since it's not set up for this repo. I'd check how it's done in our core integrations repo. Also I noticed a lot of tests for Mem0 are being skipped could you see why that's the case? |
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
| COHERE_API_KEY: ${{ secrets.COHERE_API_KEY }} | ||
| MEM0_API_KEY: ${{ secrets.MEM0_API_KEY }} | ||
| GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }} | |
| GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }} | |
| AWS_REGION: "us-east-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And right before integration-tests: add this block
# Do not authenticate on PRs from forks and on PRs created by dependabot
- name: AWS authentication
id: aws-auth
if: github.event_name == 'schedule' || (github.event.pull_request.head.repo.full_name == github.repository && !startsWith(github.event.pull_request.head.ref, 'dependabot/'))
uses: aws-actions/configure-aws-credentials@61815dcd50bd041e203e49132bacad1fd04d2708
with:
aws-region: ${{ env.AWS_REGION }}
role-to-assume: ${{ secrets.AWS_CI_ROLE_ARN }}
| aws-region: ${{ env.AWS_REGION }} | ||
| role-to-assume: ${{ secrets.AWS_CI_ROLE_ARN }} | ||
|
|
||
| - name: Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we also have this in the bedrock integration tests
| - name: Run | |
| - name: Run | |
| if: success() && steps.aws-auth.outcome == 'success' |
|
@anakin87 could we ask for your help on what might be going wrong with the AWS auth setup in tests? |
|
@sjrl try adding on the test workflow, on top level It seems it also worked on this repo in the past |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of the work on this!
Let's make sure to add a pydoc for this in a follow up PR
Related Issues
Proposed Changes:
Key Changes
Mem0MemoryStoreusing the latest user message as the query.How did you test it?
Notes for the reviewer
Support for
Memory.from_configwill be revised in a separate PR as it has a slightly different implementation than mem0MemoryClient.https://docs.mem0.ai/platform/platform-vs-oss
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.