Skip to content

fix(deps): cap pyarrow below 26 on Python 3.12 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tkislan wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(deps): cap pyarrow below 26 on Python 3.12 #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ddcf79
fix(deps): cap pyarrow below 26 on Python 3.12
tkislan Oct 23, 2026
efd02c1
ci: smoke-test a lock-less install of the built wheel
tkislan Oct 23, 2026
b203b0f
chore(deps): drop the CVE note from the Python 3.12 pyarrow requirement
tkislan Oct 23, 2026
8fb3f3c
ci: write the lock-less smoke export check as a heredoc script
tkislan Oct 25, 2026
68c2ae4
ci: rename the lock-less install smoke job to Wheel Install Check
tkislan Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,56 @@ jobs:
path: coverage-data/coverage.xml
retention-days: 30

# Other jobs take the toolkit's dependencies from poetry.lock; this one resolves
# the wheel's own requirements, as `pip install deepnote-toolkit` does for users.
wheel-install-check:
name: Wheel Install Check - Python ${{ matrix.python-version }}
runs-on: ubuntu-latest
timeout-minutes: 15
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
steps:
- name: Checkout code
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4
with:
fetch-depth: 0
fetch-tags: true
persist-credentials: false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: ${{ matrix.python-version }}

- name: Install Poetry
uses: snok/install-poetry@76e04a911780d5b312d89783f7b1cd627778900a # v1
with:
version: ${{ env.POETRY_VERSION }}

- name: Build wheel
id: build
uses: ./.github/actions/build-wheel

- name: Install wheel without the lock and check the exports
env:
WHEEL_PATH: ${{ steps.build.outputs.wheel-path }}
run: |
python -m venv /tmp/smoke
/tmp/smoke/bin/python -m pip install "${WHEEL_PATH}[server]"
# Leave the checkout so the import loads the installed wheel, not ./deepnote_toolkit.
cd /tmp
/tmp/smoke/bin/python - <<'EOF'
import deepnote_toolkit

# safe_import logs failed imports instead of raising, so check the exports exist.
expected = ["DeepnoteChart", "execute_sql", "execute_sql_with_connection_json"]
missing = [name for name in expected if not hasattr(deepnote_toolkit, name)]
if missing:
raise SystemExit(f"deepnote_toolkit is missing exports: {missing}")
EOF

audit-prod:
name: Audit - Production
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ dependencies = [
"pyarrow>=16.0.0,<18.0.0; python_version == '3.10' and sys_platform == 'darwin'",
"pyarrow>=13.0.0,<=17.0.0; python_version == '3.11' and sys_platform != 'darwin'",
"pyarrow>=16.0.0,<=18.0.0; python_version == '3.11' and sys_platform == 'darwin'",
"pyarrow>=23.0.1; python_version == '3.12'", # 23.0.1 patches CVE-2026-25087 (GHSA-rgxp-2hwp-jwgg)
# pyarrow 26 requires NumPy 2 at import time without declaring it, and 3.12 is on numpy<2.
"pyarrow>=23.0.1,<26; python_version == '3.12'",
"pyarrow>=23.0.1; python_version >= '3.13'", # 3.10/3.11 stay <17 via databricks-sqlalchemy 1.x (SQLAlchemy 1.x compat)

"db-dtypes>=1.2.0,<1.4",
Expand Down
Loading