Repository navigation
Fix: Include Libxc functional IDs in LR and DFPT tests - #8172
Merged
Merged
Conversation
mohanchen
added
Bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
The tests added in #8069 and #8164 fail to compile with Libxc 7.1.2 because
<xc.h>does not provide functional IDs such asXC_LDA_X. Include<xc_funcs.h>explicitly in both test files, andMODULE_LR_xc_kxcandMODULE_DFPT_xc_analytic_serialcan compile correctly.