Refine agent governance global dependency downgrade#7591
Open
QuantumMisaka wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Follow-up to #7586.
Unit Tests and/or Case Tests for my changes
GlobalV/GlobalC/PARAMreferences blocks;Exact Verification Performed
python3 -m unittest tools/03_code_analysis/test_agent_governance_check.py -q- passed: 38 tests, OK.python3 tools/03_code_analysis/agent_governance_check.py --base upstream/develop --head HEAD --format text- passed:Agent governance check: no findings.git diff --check upstream/develop...HEAD- passed with no output.What's changed?
This PR is a follow-up to #7586. PR #7586 intentionally relaxed the initial agent governance gate because the previous "any added global dependency blocks" behavior was too strict for the current legacy migration stage and was blocking normal development PRs.
During the review discussion on #7586, we identified two risks with a blanket downgrade from error to warning:
GlobalV,GlobalC, orPARAMdependency debt to grow.PR metadata completeness, which is unrelated to global-state migration and should remain a deterministic blocker.This PR keeps #7586 as the merged baseline, but refines the policy into a PR-level global dependency budget:
GlobalV/GlobalC/PARAMreferences in added code lines.This should avoid over-strict CI behavior for normal development and migration work while still preventing new global dependency debt from increasing unnoticed.
The PR also:
PR metadata completenessto blocker severity;AGENTS.md, the PR template, Copilot instructions, and CodeRabbit instructions to describe the budget rule consistently;Governance Checklist
git diff --check upstream/develop...HEAD.INPUT Parameter Changes
docs/parameters.yamlupdated: not applicable.docs/advanced/input_files/input-main.mdupdated: not applicable.Core Module Impact
Governance Exception
GlobalV/GlobalC/PARAMreferences, related documentation, and warning visibility.