Fix and harden abacuslite ASE interface#7588
Open
QuantumMisaka wants to merge 4 commits into
Open
Conversation
Collaborator
|
noted. Regards. |
kirk0830
reviewed
Jul 4, 2026
kirk0830
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the vendored
abacusliteASE interface and ports the ATST-Tools fixes that are suitable for upstream ABACUS:*.bak.Nfiles and ignore non-canonical suffixes.dipolefrom the advertised ASE implemented properties.FixAtoms/FixCartesianASE constraints to ABACUS mobility flags.Fixes #7540
Fixes #7544
Fixes #7546
Tests
Run from
interfaces/ASE_interface/abacusliteafterpython3 -m pip install -e ../ --no-deps:python3 ./io/generalio.py -vpython3 ./io/legacyio.py -vpython3 ./io/latestio.py -vpython3 ./utils/ksampling.py -vpython3 core.py TestAbacusCalculator.test_version_number_check TestAbacusCalculator.test_property_keywords_reject_conflicting_user_parameters TestAbacusCalculator.test_property_keywords_reject_conflicting_properties TestAbacusCalculator.test_dipole_property_is_not_implemented -vgit diff --check -- interfaces/ASE_interface/abacuslite/core.py interfaces/ASE_interface/abacuslite/io/generalio.py interfaces/ASE_interface/abacuslite/io/legacyio.py interfaces/ASE_interface/abacuslite/io/latestio.pyThe local shell did not have
abacusormpirunin PATH, so the full calculator execution test remains covered by upstream CI.