fix: nspin = 2 for init_chg=dm#6975
Merged
mohanchen merged 6 commits intodeepmodeling:developfrom Feb 26, 2026
Merged
Conversation
mohanchen
added
the
Features Needed
…_chg=hr tests The CSR file format was updated (commit 9c1a061) with spin info, ucell data, and CSR comment block headers, but the unit test still wrote the old format, causing parse failures. Rewrote write_test_csr to use write_dmr_csr so the test always produces the current format. Added HR read tests for nspin=1 and nspin=2 covering the init_chg=hr code path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mohanchen
reviewed
Feb 25, 2026
Use POSIX mkdir() from <sys/stat.h> instead of system("mkdir -p")
for C++11 compatibility, and remove system("rm -rf") cleanup calls.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #6974
Unit Tests and/or Case Tests for my changes
What's changed?
Any changes of core modules? (ignore if not applicable)