[Fix] 020-twilio-media-streams-node — fix async race dropping Twilio audio#97
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
…-media-streams-node express-ws does not await async WebSocket handlers, so Twilio message listeners were registered after the Deepgram connection was established, causing early audio frames to be silently dropped. Moved Twilio WS handlers before async Deepgram setup and buffer media until ready. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
Contributor
Author
Code ReviewOverall: CHANGES REQUESTED Integration genuinenessN/A — bug fix PR. Code qualityThe fix correctly addresses the root cause (async handler race condition) with the same buffering pattern. However:
PR #95 addresses all of these and is the most complete fix for this issue. RecommendationPlease close this PR in favor of #95. Please address the items above. The fix agent will pick this up automatically. Review by Lead on 2026-04-01 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
express-wsdoes not await async WebSocket handlers. The originalasync (twilioWs) => { ... }handler awaiteddeepgram.listen.v1.createConnection()andwaitForOpen()before registeringtwilioWs.on('message'), so early Twilio audio frames were silently dropped — no audio reached Deepgram, causing test timeouts./mediaWS handler synchronous; Twilio event listeners register immediatelymediaQueueuntil the Deepgram socket is open, then flushedstop(matches real Twilio behavior)Test plan
npm teston this example with live Deepgram credentials<Stream>URL🤖 Generated with Claude Code