[Fix] 020-twilio-media-streams-node — update to SDK v5 createConnection/waitForOpen API

[github-actions]

Fix: 020-twilio-media-streams-node regression

Root cause: The example used the old listen.v1.connect() pattern which immediately opens a WebSocket, then called dgConnection.connect() again causing a reconnection cycle. It also used the deprecated sendCloseStream() method and manually parsed JSON from the message event (which the SDK v5 already provides as parsed objects).

Changes

• src/index.js:
  • Use createConnection() + connect() + waitForOpen() pattern per SDK v5 docs
  • Replace sendCloseStream({ type: 'CloseStream' }) with sendFinalize({ type: 'Finalize' })
  • Simplify message handler — SDK v5 already parses JSON before emitting message events

Test plan

• CI runs the test and passes
• Deepgram transcription still receives recognizable words from spacewalk audio

---

Fixed by engineer on 2026-03-30

[github-actions]

Code Review

Overall: APPROVED

Integration genuineness

Pass — Twilio SDK (twilio ^5.4.0) is a dependency, src/index.js imports it and generates real TwiML with <Connect><Stream> for Twilio Media Streams. .env.example lists TWILIO_ACCOUNT_SID, TWILIO_AUTH_TOKEN, and TWILIO_PHONE_NUMBER. Test exits 2 on missing credentials and makes real Deepgram API calls with Twilio-formatted WebSocket messages.

Code quality

• Official Deepgram SDK used (@deepgram/sdk ^5.0.0) ✓
• No hardcoded credentials ✓
• Error handling covers main failure cases ✓
• The three changes are correct for SDK v5:
  • connect() → createConnection() + connect() + waitForOpen() separates connection creation from opening
  • sendCloseStream() → sendFinalize() uses the current API
  • Message handler simplified — SDK v5 already parses JSON before emitting message

Documentation

• README accurately describes the end result ✓
• All env vars documented with where-to-find links ✓
• Run instructions are complete ✓

Tests

• Credential check runs first, before app import ✓
• Exit code 2 for missing credentials ✓
• Real API calls (downloads audio, streams to Deepgram) ✓
• Asserts meaningful content (checks for spacewalk/astronaut/nasa keywords) ✓

---

✓ All checks pass. Marking review passed.

---

Review by Lead on 2026-03-30