Prepare Imp 0.8.1 ACP patch release - #279
Conversation
deepfates
left a comment
There was a problem hiding this comment.
Independent metadata/release review of 5ac096c: no blocking findings.
Verified the four-file metadata delta and complete v0.8.0..HEAD change set: only the previously reviewed ACP presentation/framing fix plus release metadata. Version, changelog and package contract agree on 0.8.1; no dependency lock, schema, model-facing behavior or MCP changes. Independently ran package contracts (14 tests, 0 failures) and documentation contracts (21 tests, 0 failures, 1 excluded), totaling 35 tests.
Upgrade/rollback wording is accurate: resolve the normal Hex dependency and commit the lock; restoring the previous application release/lock requires no data migration but restores the old defects. Notes explicitly exclude historical content reconstruction and a full-result retrieval endpoint. Keep #278 open for authorized publication and released-consumer evidence. This review does not authorize tagging, public Hex publication, or deployment; exact-head CI remains required.
|
Local release artifact at metadata head5ac096ca:
Nothing uploaded or tagged. Exact-head CI is running. After authorized public publication, Dwell must resolve from Hex and commit its lock before its draft regression can pass on the ordinary path. Rollback restores the previous application release/lock: no schema migration is introduced, but the previous capture/framing/display defects return. Native Dwell records stay complete; the fix does not recover content already omitted from historic ACP transcripts. |
|
CI correctly caught one metadata omission in the first release-prep head:
|
deepfates
left a comment
There was a problem hiding this comment.
Independent follow-up on corrected head d03a90b. My earlier metadata review missed priv/public_api.json's package_version; this supersedes that release-completeness assessment.
Verified the delta from 5ac096c is exactly the generated manifest version 0.8.0 -> 0.8.1, with no runtime/API surface change. Independently ran mix test test/public_api_manifest_test.exs: 25 tests, 0 failures. The contract compares the complete checked-in manifest with the compiled packaged API and Mix version. Previous package/documentation checks remain applicable; exact-head CI must still pass.
No blocking findings in the corrected delta. No tag, upload or deployment performed; publication/consumer evidence remains outstanding.
Prepares #278; keep that issue open until authorized publication and the released Dwell cutover are evidenced. The ACP implementation is already merged in #277.
Set version 0.8.1, update its package contract and generated public API manifest, and document the two patch fixes: truthful/readable bounded ACP results and complete local JSON frames under the unchanged frame cap. No model-facing, MCP, dependency-pin or schema change. Applications keep
{:imp, "~> 0.8"}, update Imp and commit the lock; rollback restores the previous application release/lock and its former defects.Validation: format check and package/documentation contract suites pass (35 tests, 0 failures, 1 excluded); after CI caught the stale manifest version, the corrected API-manifest/package suites pass (39 tests, 0 failures). The regenerated manifest changes only package_version. The implementation's full CI matrix passed before #277 merged; its full local gate passed 3,601 tests plus doctests/properties. Release preparation CI verifies this exact metadata head separately.
This PR does not tag, publish to Hex, or deploy. Public Hex publication needs explicit owner approval. Dwell#196 must consume the released version in its ordinary lock before shipping; there is no temporary pin. Haven#102 is independently compatible but does not reconstruct historical omitted results or provide in-Haven full-result retrieval.