fix(vm): make virtualMachineCIDRs optional#2591
Draft
diafour wants to merge 1 commit into
Draft
Conversation
Allow ModuleConfig without spec.settings.virtualMachineCIDRs. What changed: - Make virtualMachineCIDRs optional in OpenAPI schema. - Stop blocking module enablement when CIDRs are not configured. - Make ModuleConfig CIDR parsing safe when the field is absent. - Skip CIDR overlap checks when virtualMachineCIDRs is not set. - New behavior when CIDRs are not configured: - Reject VMs with explicit Main network. - Reject VMIP usage and VirtualMachineIPAddress resources. - Validate changing ModuleConfig: protect removing CIDRs if VMIP leases are present. Also updated docs and tests. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
69366eb to
a8a31b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries