[dmt] fix mount points rules#420
Draft
diyliv wants to merge 4 commits into
Draft
Conversation
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sys,/dev,/procare now ignored by both container and templates mount-points rules. CSI drivers commonly mount these host paths at runtime without declaring them in Helm templates.files:support to templates rule:mountPointsFilestruct now parsesfiles:alongsidedirs:, matching the container rule behaviour.filepath.Walkerror handling:return errchanged toreturn nil+ error reporting — a single permission error no longer stops the entire tree walk, which would skip allmount-points.yamlfiles below the problematic directory.collectMountPointsDirsnow logs walk/read/parse errors vialog.Warninstead of silently swallowing them.Context
The
csi-netappmodule CI was failing with many false warnings from the templates rule:These are host system paths that the CSI driver accesses at runtime — they are correct but absent from Helm templates. The
/syspath was explicitly requested to be excluded. Thefiles:entries inmount-points.yamlwere silently ignored by the templates rule. And the container rule swallowed all read/parse errors, making bugs invisible.Example
Before (CI output for
csi-netapp):After:
/devis skipped as a built-in system path. Remaining module-specific paths (/host,/etc/iscsi,/etc/multipath, etc.) can be excluded via module config: