chore(sbom): generate SBOM only for final images#77
Draft
Conversation
reyreavman
force-pushed
the
chore/sbom/generate-sbom-on-final-images
branch
2 times, most recently
from
9065d69 to
f319582
Compare
Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
reyreavman
force-pushed
the
chore/sbom/generate-sbom-on-final-images
branch
from
f319582 to
7291da9
Compare
Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
reyreavman
force-pushed
the
chore/sbom/generate-sbom-on-final-images
branch
from
7291da9 to
56f4a3a
Compare
nervgh
commented
Apr 22, 2026
| // convergeSbomByImagesSets generates SBOM for images respecting dependency order. | ||
| // It iterates over ImagesSets sequentially (set by set) to ensure base image SBOMs | ||
| // are generated before dependent images. Within each set, images are processed in parallel. | ||
| func (phase *BuildPhase) convergeSbomByImagesSets(ctx context.Context) error { |
Collaborator
Author
There was a problem hiding this comment.
We have code duplication between
delivery-kit/pkg/build/build_phase.go
Line 244 in 7291da9
delivery-kit/pkg/build/build_phase.go
Line 159 in 7291da9
I mean the function convergeSbomByImagesSets looks redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.