Skip to content

[plugins] Advise the cli-download role on a 403 from registry-packages-proxy #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Glitchy-Sheep wants to merge 1 commit into from
Closed

[plugins] Advise the cli-download role on a 403 from registry-packages-proxy #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/dist/cmd/errdetect/diagnose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func Diagnose(err error) *diagnostic.HelpfulError {
return help(err, "registry-packages-proxy: forbidden (403)",
"the identity may not download the CLI",
"bind the ClusterRole 'd8:registry-packages-proxy:cli-download' to the user/group",
"authorization is cached ~5 min - after binding, retry with a fresh token")
"a denied check is cached ~30s - after binding the role, wait half a minute and retry with the same token")
case errors.Is(err, rpp.ErrNotFound):
return help(err, "registry-packages-proxy: version not found (404)",
"this deckhouse-cli version is not published",
Expand Down
7 changes: 5 additions & 2 deletions internal/plugins/cmd/errdetect/diagnose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,14 @@ func Diagnose(err error) *diagnostic.HelpfulError {
return help(err, "registry-packages-proxy: unauthorized (401)",
"no accepted Bearer token (a client-certificate kubeconfig is not enough)",
"use a kubeconfig with an OIDC token (Kubeconfig Generator or 'd8 login')")
// Plugins are downloaded over /v1/images/, which kube-rbac-proxy authorizes
// through the deployments/cli-binary subresource: that is the cli-download
// role, not packages-download (it covers /v1/packages/).
case errors.Is(err, rpp.ErrForbidden):
return help(err, "registry-packages-proxy: forbidden (403)",
"the identity may not download plugins",
"bind the ClusterRole 'd8:registry-packages-proxy:packages-download' to the user/group",
"authorization is cached ~5 min - after binding, retry with a fresh token")
"bind the ClusterRole 'd8:registry-packages-proxy:cli-download' to the user/group",
"a denied check is cached ~30s - after binding the role, wait half a minute and retry with the same token")
case errors.Is(err, rpp.ErrNotFound):
return help(err, "registry-packages-proxy: plugin or version not found (404)",
"this plugin or version is not published",
Expand Down
2 changes: 1 addition & 1 deletion internal/plugins/cmd/errdetect/diagnose_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func TestDiagnose(t *testing.T) {
wantSol string
}{
{"401", rpp.ErrUnauthorized, "unauthorized (401)", "OIDC"},
{"403", rpp.ErrForbidden, "forbidden (403)", "packages-download"},
{"403", rpp.ErrForbidden, "forbidden (403)", "cli-download"},
{"404", rpp.ErrNotFound, "plugin or version not found (404)", "deckhouse-cli/plugins"},
{"5xx", rpp.ErrUpstream, "upstream error (5xx)", "registry-packages-proxy pods"},
{"discovery", rpp.ErrEndpointDiscovery, "endpoint discovery via the Kubernetes API failed", "--rpp-endpoint"},
Expand Down
Loading