Gate legacy element attestations behind the operator role#27
Open
heijiLee wants to merge 1 commit into
Open
Conversation
Sanctions (A-01), AccreditedInvestor (A-03), and QualifiedPurchaser (A-13) had ungated, eventless attestation setters, diverging from the Governed/onlyOperator + event pattern used by the six CMP-001 elements (Jurisdiction, UsTaxResident, etc). Extend Governed on all three, gate setBlocked/setAccredited/setQp with onlyOperator, and emit an event per change. Lockup (C-01) has no settable mutator (state is injected via IAcquisitionSource), so it is left untouched. Add per-element outsider-auth-revert and set+emit tests to Elements.t.sol, written RED first against the unmodified elements. Existing fixtures (Engine.t.sol, IntegrationBase.sol, MultiRecipe.t.sol, SwapFlow.t.sol) call these setters from the deploying test contract itself, i.e. as owner, which onlyOperator already admits, so no fixture changes were needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26. Closes the hardening divergence recorded in D008: the legacy mock elements (
SanctionsA-01,AccreditedInvestorA-03,QualifiedPurchaserA-13) had ungated, eventless setters while the CMP-001 elements are operator-gated.GovernedwithonlyOperatorsetters and*Setevents matching the newer elements' shapeLockup(C-01) verified to have no mutator — untouchedforge test --offline233/233 (+6: per-element outsider auth revert + set/emit)