Repository navigation
ci: log in to Docker Hub when the secrets are present and retry an image build once on a 429 (#891) - #965
Merged
Conversation
…age build once on a 429 (#891) Container Tests built `mcp-debugger:local` against Docker Hub anonymously, under the per-IP rate limit every GitHub-hosted runner shares: four `429 Too Many Requests` on the base-image manifests on 2026-10-09 alone, turning a docs-only merge's Test Summary red on main. The job now logs in with the repository's DOCKER_USERNAME/DOCKER_PASSWORD when a run has them (same pinned docker/login-action as release.yml; fork and Dependabot PRs have no secrets and keep building anonymously), and a build whose output contains the 429 is retried once after 60 s. The canary's docker build guard gets the same login. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y3ULnoVSoCZ5t2Y8d98Ctv
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #891.
What changed
Container Tests(ci.yml) and the canary'sdocker build guard(canary.yml) pulled their base images from Docker Hub anonymously, under the per-IP rate limit every GitHub-hosted runner on that egress shares. On 2026-10-09 that produced four429 Too Many Requestson thenode:26-slim/dart:3.13manifests, twice on one docs-only PR and twice on itsmainpush run, somain's Test Summary went red for a merge that changed no code.DOCKER_USERNAMEto its environment and writes aloginoutput (thesecretscontext is not available in a step'sif);docker/login-actionruns on that output, at the SHArelease.ymlalready pins. Fork and Dependabot PRs carry no secrets, so they keep building anonymously, as before. Authenticated pulls are not counted against the anonymous per-IP window.docker buildruns underset -o pipefailthroughtee; a failed build whose log contains429 Too Many Requestsis retried once after 60 s with a::warning::annotation. Any other failure fails at once, as before; a second 429 fails with an::error::.Workflow files only, so no changelog fragment (the gate covers
src/,packages/,tools/andpackage.json).Verification
Login Succeededin Container Tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y3ULnoVSoCZ5t2Y8d98Ctv