[codex] fix terminal Mac Option symbols#97
Draft
jimmystridh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, the embedded terminal did not allow keyboard-layout characters produced with the Option key. In practice this meant users could not type currency symbols such as Option+3 for
$or Option+4 for€in the terminal.Root cause
The xterm instance was created with
macOptionIsMeta: true. That makes xterm treat Option as Meta and convert Option-key input into escape/meta sequences instead of allowing macOS keyboard layouts to emit printable characters.Fix
macOptionIsMetatofalsefor new terminal instances so Option remains available for printable layout characters.Validation
pnpm --filter @slayzone/app buildpnpm --filter @slayzone/terminal typecheckpnpm --filter @slayzone/app exec playwright test --config playwright.config.ts e2e/terminal/30-terminal-core-behavior.spec.ts -g "lets macOS Option"