Fix GUI subprocess PATH#93
Open
jimmystridh wants to merge 2 commits into
Open
Conversation
a5e4265 to
81c193e
Compare
81c193e to
daff742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GUI-launched Git/GitHub commands missing user PATH.
SlayZone was spawning Git worktree operations directly from Electron PATH and running gh through interactive zsh. That broke Git LFS hooks when Homebrew was missing from PATH, and let zsh prompt/gitstatus noise make gh PR listing fail.
This moves enriched PATH into the shared platform shell helper, applies it to worktree subprocesses and setup scripts, and runs gh directly with that environment so shell startup files cannot contaminate stderr.
Validation:
Greptile Summary
This PR fixes GUI-launched subprocess PATH handling for Git and GitHub CLI workflows. The main changes are:
ghdirectly through the resolved binary path instead of through the interactive shell.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
ghbinary directly to avoid shell startup output corrupting command results.Reviews (1): Last reviewed commit: "fix(platform): pass Windows platform tes..." | Re-trigger Greptile
Context used: