Skip to content

Add negative input handling #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikhilwoodruff wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add negative input handling #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7326815
Add negative input handling
nikhilwoodruff Sep 9, 2020
77349a8
Replace removed whitespace
nikhilwoodruff Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ballpark/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,15 @@ def unwrapped_function(values, *vargs, **kwargs):
if scalar:
values = [values]

results = fn(values, *vargs, **kwargs)
# Handle negative inputs by converting to positive, then correcting the output

is_negative = list(map(lambda x : x < 0, values))
multipliers = [-1 if negative else 1 for negative in is_negative]
positive_inputs = [value * multiplier for value, multiplier in zip(values, multipliers)]

positive_results = fn(positive_inputs, *vargs, **kwargs)

results = ["-" + positive_result if negative else positive_result for positive_result, negative in zip(positive_results, is_negative)]

if scalar:
results = results[0]
Expand Down