-
Notifications
You must be signed in to change notification settings - Fork 0
Cut release qualification over to v2 evidence #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
.agents/plans/02-eval-engineering/evidence/phase-5-review.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Phase 5 review and throughput checkpoint | ||
|
|
||
| Phase 5 replaces release authority with explicit v2 report, catalog, and measured | ||
| artifact inputs. Every verdict writes a deterministic report-ID decision record. | ||
| Release scans committed records, validates the full digest set, rebuilds and | ||
| rechecks the exact artifact, and remains intentionally blocked by | ||
| `canary-not-enabled` until Phase 9. | ||
|
|
||
| Interrogate fixed workflow flag/catalog/artifact mismatches, report-ID record | ||
| handoff, full artifact comparison, per-attempt host configuration, catalog hashing, | ||
| checksum ordering, and the missing required-case promotion. The final four-model | ||
| recheck found no blocker. | ||
|
|
||
| Throughput checkpoint: | ||
|
|
||
| - The live v2 catalog promotes exactly seven current release cases and leaves | ||
| uncalibrated cases report-only. | ||
| - A new scenario needs its scenario definition, release-policy entry when promoted, | ||
| and one policy/test update. It does not require a qualifier branch. | ||
| - The historical summary path remains as 39 symbol references across the legacy | ||
| helper tests and 743-line transitional qualifier module. It has no CLI or release | ||
| authority and can be deleted after migration evidence no longer needs comparison. | ||
| - The vertical slice passes the full gate. Later phases may proceed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| export const RELEASE_PASS_RATES: Readonly<Record<string, number>> = { | ||
| "happy-path": 1, | ||
| "plan-only-stops": 1, | ||
| "goal-change-refused": 1, | ||
| "failing-gate-blocks": 0.9, | ||
| "resumes-after-interruption": 1, | ||
| "unprovable-claim-refused": 0.9, | ||
| "continuation-accepted": 1, | ||
| }; | ||
|
|
||
| export const RELEASE_MIN_PROVIDERS = 2; | ||
| export const RELEASE_MIN_SCORED_ATTEMPTS = 3; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the scheduled/dispatch
matrix-evalsjob, a NOT VERIFIED or INCONCLUSIVE result exits this step nonzero, butcontinue-on-error: trueconverts that into a successful conclusion and the following upload step normally succeeds; the eval-run step is also allowed to fail, and there is no final step that re-raises either outcome. Consequently a failed release qualification leaves the workflow green, masking regressions from the schedule; retain the continuation for artifact publication but add a final gate that fails from the recorded qualifier outcome.Useful? React with 👍 / 👎.