-
Notifications
You must be signed in to change notification settings - Fork 0
Bind eval results to exact provenance #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions
33
.agents/plans/02-eval-engineering/evidence/phase-3-pilot.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "schemaVersion": 1, | ||
| "recordedAt": "2026-08-25T04:14:14.980Z", | ||
| "scenario": "happy-path", | ||
| "modelRoute": "opencode/gpt-5.6-sol", | ||
| "opencodeVersion": "1.18.6", | ||
| "passed": true, | ||
| "artifact": { | ||
| "packageVersion": "8.1.1", | ||
| "sourceCommit": "04d3f6ee34bc92373982f9599beb6ce66c08f6c8", | ||
| "sourceTreeSha256": "sha256:605b10580561bd0bc592614b550eb5516ec9240fd2553dd3e92e3a36a30821d9", | ||
| "tarballSha256": "sha256:c89f7363248ccc3e3f69728c1aa42044a25938cd533e470d9f73ef08bc64ad24", | ||
| "unpackedManifestSha256": "sha256:398e6003b3c4d16f5e49dad9dbe734666149ee753e803d020501c863c19f0183" | ||
| }, | ||
| "evaluator": { | ||
| "sourceCommit": "04d3f6ee34bc92373982f9599beb6ce66c08f6c8", | ||
| "caseCatalogSha256": "sha256:b9bd76c55d20db6daca1b40bf4118fae66f829dafec4b9388288d6a603a47be3", | ||
| "policyCatalogSha256": "sha256:708363968ed83fedf84f0310baa65f2b8b172c8c5ccdc0d090cf50bae2b51c9d", | ||
| "graderBundleSha256": "sha256:3eba0223d2f005abd4c429e05dd86ddb4c20a495725be69d852ea8d36f09431a" | ||
| }, | ||
| "hostConfigSha256": "sha256:fc5de04f3e595f7c84d9310369a9ebc3118600c1bbc342be67e65d8d72f5b64e", | ||
| "actors": [ | ||
| { "role": "manager", "requestedModelId": "opencode/gpt-5.6-sol", "actual": "observed", "sessionCount": 1 }, | ||
| { "role": "reviewer", "requestedModelId": "opencode/gpt-5.6-sol", "actual": "observed", "sessionCount": 1 } | ||
| ], | ||
| "instructions": [ | ||
| { "source": "guidance", "name": "flow-plan", "sequence": 0, "sha256": "sha256:f9d2f6dbf60f8be5a53a3959517eb9e5307624e75e7aa25960d76db3c8c71d7a", "bytes": 5685 }, | ||
| { "source": "guidance", "name": "flow-run", "sequence": 1, "sha256": "sha256:9f451a740456a7a59aca02f4485bdcfe5f64ad3fb57a48980fa09cde40c08050", "bytes": 7933 } | ||
| ], | ||
| "transcriptSha256": "sha256:875a85c8007daa436be268553319967c35b449ab4ad5d0e663a9a80e8063db0d", | ||
| "redactionScanPassed": true, | ||
| "unsupportedClaim": "Observed provider and model fields do not independently establish family, gateway, or revision. Phase 4 must preserve actual v2 model identity as unobserved unless those fields become independently available." | ||
| } |
39 changes: 39 additions & 0 deletions
39
.agents/plans/02-eval-engineering/evidence/phase-3-review.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Phase 3 Interrogate review | ||
|
|
||
| ## Intent | ||
|
|
||
| Phase 3 must bind real eval output to exact source, packed bytes, evaluator inputs, | ||
| host configuration, requested and observed actors, delivered instructions, and a | ||
| redacted transcript. It must preserve endpoint and identity limitations rather | ||
| than fill missing observations from configuration. | ||
|
|
||
| ## Acted on | ||
|
|
||
| - The runner now consumes provenance helpers and emits the binding on every result. | ||
| - Tarball bytes are checked before inspection and after cache installation. | ||
| - Unpacked manifests bind file and directory type. Other archive entry types are | ||
| rejected. | ||
| - Reviewer child endpoint failures remain explicit, including partial discovery. | ||
| - Multi-session actor identity fails closed when any session is unobserved. | ||
| - Transcript redaction covers object keys, short sensitive-field values, paths, | ||
| and credential-shaped strings. | ||
| - Instruction text rejects malformed Unicode and hashes actual UTF-8 delivery. | ||
| - Requested manager and reviewer identities are emitted separately from raw host | ||
| observations. Reviewer model and step configuration are included in host hashes. | ||
| - Pure actor parsing moved out of the large harness into `host-observation.ts`. | ||
|
|
||
| ## Lead judgment | ||
|
|
||
| The pinned host independently exposes provider and model fields, but not the full | ||
| family, gateway, and revision tuple required by v2 `ModelIdentity`. The legacy | ||
| pilot retains the raw observation. Phase 4 must emit actual identity as | ||
| `unobserved` unless a later host exposes all required fields. Cross-family claims | ||
| remain unavailable otherwise. | ||
|
|
||
| ## Verdict | ||
|
|
||
| `VERIFIED`. Four-model recheck found no unresolved blocker. The final paid packed | ||
| `happy-path` passed with observed manager and reviewer roles, two delivered | ||
| guidance records, exact artifact/evaluator/host hashes, and a clean transcript | ||
| redaction scan. The full repository gate passes 462 tests, one intentional skip, | ||
| and zero failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a
flow_guidancecall is pending or ends inerror, this branch still adds it toguidanceLoads;run.tsthen hashes the empty output or error message as if those bytes were delivered instructions. Aborted and tool-error attempts therefore receive incorrect instruction provenance. Restrict delivery records to completed calls with an observed output, while retaining failed calls only in the transcript.Useful? React with 👍 / 👎.