fix: add healthcheck test command, fixes #29#30
Merged
Conversation
Addresses two issues: - [Podman requires a healthcheck test command](ddev#29), and will fail without it. - Any accurate healthcheck test command for phpMyAdmin will [take forever to run](ddev#2) (80+ seconds!) This commit adds a placeholder healthcheck test command that always returns true as soon as the container is responsive in local development, addressing both issues.
stasadev
approved these changes
Mar 11, 2026
Member
stasadev
left a comment
stasadev
left a comment
There was a problem hiding this comment.
Respects an earlier issue as to why the test command was removed in the first place
Thank you, looks good to me.
stasadev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
Must define a healthcheck command for all healthchecks#29Podman requires a
healthcheck.testcommand will fail with the following error if it's not defined:Note: The
testcommand is a required part of the Docker Compose spec forhealthcheck, but different Docker provider tools may choose to treat it as ignored/skip if not present, or to treat it as a fatal issue.How This PR Solves The Issue
This PR adds a simple "always healthy" shell return for the
testcommand.It meets 3 goals:
testcommand requirementtestcommand was removed in the first place, where an accurate healthcheck can cause the container to report healthy way too slowly (fix: healthcheck makes it come up too slowly #2 )testcommand later(Can confirm, when testing a couple of different variant son an accurate healthcheck: the response time was all over the place and very inconsistent. Sometimes it came back within half a second, other times it took over 80 seconds. Not too sure why!)
Another alternative would be to disable the healthcheck altogether, if it's not needed for local development with DDEV. This is also following the Docker Compose spec, and Podman will accept it:
Manual Testing Instructions
The phpMyAdmin project container should successfully build and run without the error.
Automated Testing Overview
This PR doesn't change the add-on's build or runtime behavior, just , so no tests need to be updated or added.
Release/Deployment Notes
This change should not impact any other code or deployment steps.
It's worth noting that setting the
healthcheckkey here should override any healthcheck later defined by the official phpMyAdmin Docker build itself, so it is good to keep it rather than omit in order to avoid being surprised by suddenly long healthcheck times.